feat: Add DashboardPlugin support to embed-widget#1950
Merged
mattrunyon merged 3 commits intodeephaven:mainfrom Apr 24, 2024
Merged
feat: Add DashboardPlugin support to embed-widget#1950mattrunyon merged 3 commits intodeephaven:mainfrom
mattrunyon merged 3 commits intodeephaven:mainfrom
Conversation
mofojed
reviewed
Apr 24, 2024
Comment on lines
+31
to
+39
| Object.entries( | ||
| layoutManager.config.settings.defaultComponentConfig ?? {} | ||
| ).forEach(([k, v]) => { | ||
| // @ts-ignore | ||
| if (config[k] === undefined) { | ||
| // @ts-ignore | ||
| config[k] = v; | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
Annoying that Object.assign doesn't have something that does this, skipping undefined. Oh well.
mofojed
approved these changes
Apr 24, 2024
mofojed
approved these changes
Apr 24, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Looks good, let's get this in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for deephaven/deephaven-plugins#215
Doesn't support multiple dashboards being opened in one embed, but some of the groundwork is there and we don't support multiple dashboards from a single widget anyway yet.