Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings from skopt using deprecated sklearn API #21

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Suppress warnings from skopt using deprecated sklearn API #21

merged 1 commit into from
Dec 10, 2019

Conversation

felker
Copy link
Member

@felker felker commented Dec 9, 2019

Closes #12. The warning is due to https://github.com/scikit-optimize/scikit-optimize still using the deprecated sklearn API as of skopt v0.5.2 (2018-03-25).

Discussed in scikit-optimize/scikit-optimize#774

They have two open PRs that address this, but they haven't been updated in months:

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   14.03%   14.03%           
=======================================
  Files         264      264           
  Lines       14536    14536           
  Branches     1907     1907           
=======================================
  Hits         2040     2040           
  Misses      12423    12423           
  Partials       73       73

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149d1c7...d085b3c. Read the comment docs.

@Deathn0t Deathn0t merged commit bda2513 into deephyper:master Dec 10, 2019
@Deathn0t
Copy link
Member

Hi @felker, thank you for your contribution, it will be much less annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation Warning: sklearn.externals.joblib
2 participants