Fixes API responses #1080
Merged
Fixes API responses #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an update to fix the changes to the workflow response from deepjavalibrary#1022. Before, we had no test that checks the response components decided by the names of Java response object properties (workflows, models, etc.). This adds some new JSON testing to help ensure that these are not accidentally changed, fixing this issue and hopefully avoiding future breakages.
frankfliu
reviewed
Sep 14, 2023
| @@ -596,6 +600,16 @@ private void testListModels(Channel channel) throws InterruptedException { | |||
| .anyMatch(w -> expectedModel.equals(w.getModelName()))); | |||
| } | |||
|
|
|||
| // Test pure JSON works | |||
| Map<String, Object> rawResult = JsonUtils.GSON.fromJson(result, Map.class); | |||
There was a problem hiding this comment.
the result has been deserialized into resp object, can we just assert each fields are not null?
There was a problem hiding this comment.
I'm not sure that helps. The issue was that I changed the property name of the list from models to wpcs. This changes both the serialization in the code and deserialization in the test, so no explicit changes were necessary in the test. I wanted to use something more raw so that the names of the fields explicitly show up in our testing
frankfliu
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to fix the changes to the workflow response from #1022. Before, we had no test that checks the response components decided by the names of Java response object properties (workflows, models, etc.). This adds some new JSON testing to help ensure that these are not accidentally changed, fixing this issue and hopefully avoiding future breakages.