Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tensorflow] Fixes string tensor implemenation #1251

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

frankfliu
Copy link
Contributor

  1. Add create(String[], Shape) to NDArray interface
  2. Implemented full string tensor for TF
  3. Fixed Onnx NDManager.create(String) implementation

Change-Id: If51e55373ac800bd2df0ed1deb937fc60fca8b70

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2021

Codecov Report

Merging #1251 (67358e3) into master (4f633b3) will increase coverage by 0.20%.
The diff coverage is 92.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1251      +/-   ##
============================================
+ Coverage     70.37%   70.57%   +0.20%     
- Complexity     5069     5090      +21     
============================================
  Files           485      485              
  Lines         22248    22286      +38     
  Branches       2379     2384       +5     
============================================
+ Hits          15656    15729      +73     
+ Misses         5386     5349      -37     
- Partials       1206     1208       +2     
Impacted Files Coverage Δ
...pi/src/main/java/ai/djl/ndarray/BaseNDManager.java 67.72% <ø> (+0.42%) ⬆️
...i/src/main/java/ai/djl/ndarray/NDArrayAdapter.java 16.14% <ø> (ø)
...n/java/ai/djl/onnxruntime/engine/OrtNDManager.java 72.22% <0.00%> (-4.25%) ⬇️
...src/main/java/ai/djl/pytorch/engine/PtNDArray.java 81.86% <ø> (ø)
...ain/java/ai/djl/onnxruntime/engine/OrtNDArray.java 70.37% <66.66%> (-2.36%) ⬇️
api/src/main/java/ai/djl/ndarray/NDArray.java 77.27% <100.00%> (+1.27%) ⬆️
api/src/main/java/ai/djl/ndarray/NDManager.java 58.55% <100.00%> (+1.12%) ⬆️
...e/src/main/java/ai/djl/mxnet/engine/MxNDArray.java 86.82% <100.00%> (ø)
.../main/java/ai/djl/tensorflow/engine/TfNDArray.java 85.76% <100.00%> (+1.47%) ⬆️
...ain/java/ai/djl/tensorflow/engine/TfNDManager.java 89.31% <100.00%> (+2.42%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f633b3...67358e3. Read the comment docs.

1. Add create(String[], Shape) to NDArray interface
2. Implemented full string tensor for TF
3. Fixed Onnx NDManager.create(String) implementation

Change-Id: If51e55373ac800bd2df0ed1deb937fc60fca8b70
@frankfliu frankfliu merged commit 6c67b00 into deepjavalibrary:master Sep 28, 2021
@frankfliu frankfliu deleted the string branch September 28, 2021 01:02
maaquib pushed a commit to maaquib/djl that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants