[basicdataset] Fixed out of bound limit #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1599 +/- ##
============================================
- Coverage 72.08% 70.88% -1.21%
- Complexity 5126 5406 +280
============================================
Files 473 504 +31
Lines 21970 23619 +1649
Branches 2351 2570 +219
============================================
+ Hits 15838 16743 +905
- Misses 4925 5594 +669
- Partials 1207 1282 +75
Continue to review full report at Codecov.
|
frankfliu
reviewed
Apr 25, 2022
| : questionInfo.answerIndexList.get(questionInfo.answerIndexList.size() - 1); | ||
| textData.preprocess( | ||
| manager, newTextData.subList(0, Math.min(lastIndex + 1, newTextData.size()))); | ||
| int limit; |
There was a problem hiding this comment.
A few comments:
- avoid use
limitas local variable, it's confusing because it's clash withthis.limit - to avoid ArrayOutOfBoundException, the following should just work:
int index = Math.min(Math.toIntExact(limit), questionInfoList.size()) -1;
QuestionInfo questionInfo = questionInfoList.get(index);
There was a problem hiding this comment.
OK, I'll modify this.
frankfliu
approved these changes
Apr 25, 2022
zachgk
reviewed
Apr 26, 2022
basicdataset/src/main/java/ai/djl/basicdataset/nlp/StanfordQuestionAnsweringDataset.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Zach Kimberg <zachary@kimberg.com>
zachgk
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Stanford Question Answering Dataset the limit is specially handled, and there exists a severe bug that if the limit is too large (or the limit is set as default) it will cause an
IndexOutOfBoundException.This PR fixed this bug and changed the test cases into a more strict one so that this bug will be detected.