Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node InferType did not pass test 'isEntityName'. #455

Closed
marcus-sa opened this issue Jun 6, 2023 · 4 comments · Fixed by #465
Closed

Node InferType did not pass test 'isEntityName'. #455

marcus-sa opened this issue Jun 6, 2023 · 4 comments · Fixed by #465

Comments

@marcus-sa
Copy link
Contributor

https://github.com/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error

  1. $ pnpm install
  2. $ nx serve frontend
  3. Open http://localhost:4200 in browser
11:22:11 AM [vite] Internal server error: Debug Failure. False expression: Unexpected node.
Verbose Debug Information: Node InferType did not pass test 'isEntityName'.
  Plugin: deepkit-type
  File: /Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/libs/ui/src/lib/deepkit-client-context.tsx
      at visitNode (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85362:11)
      at visitEachChildOfTypeReferenceNode (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85772:32)
      at visitEachChild (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85603:35)
      at searchArgument (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:1880:32)
      at visitArrayWorker (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85415:51)
      at visitNodes2 (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85386:21)
      at visitEachChildOfTypeReferenceNode (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85773:13)
      at visitEachChild (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85603:35)
      at ReflectionTransformer.resolveTypeParameter (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:1888:50)
      at ReflectionTransformer.extractPackStructOfTypeReference (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:1776:22)
      at ReflectionTransformer.extractPackStructOfType (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:1024:22)
      at ReflectionTransformer.getTypeOfType (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:2016:14)
      at visitor (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:613:39)
      at visitNode (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85353:21)
      at visitEachChildOfBinaryExpression (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:86099:32)
      at visitEachChild (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85603:35)
      at visitor (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:522:20)
      at visitNode (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85353:21)
      at visitEachChildOfExpressionStatement (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:86203:32)
      at visitEachChild (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85603:35)
      at visitor (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:522:20)
      at visitArrayWorker (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85415:51)
      at visitNodes2 (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85386:21)
      at visitEachChildOfBlock (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:86190:13)
      at visitEachChild (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85603:35)
      at visitor (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:522:20)
      at visitNode (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85353:21)
      at visitEachChildOfIfStatement (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:86210:32)
      at visitEachChild (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85603:35)
      at visitor (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:522:20)
      at visitArrayWorker (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85415:51)
      at visitNodes2 (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85386:21)
      at visitEachChildOfBlock (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:86190:13)
      at visitEachChild (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85603:35)
      at visitor (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:522:20)
      at visitNode (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85353:21)
      at visitFunctionBody (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85559:21)
      at visitEachChildOfArrowFunction (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:86055:13)
      at visitEachChild (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85603:35)
      at visitor (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:522:20)
      at visitArrayWorker (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85415:51)
      at visitNodes2 (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85386:21)
      at visitEachChildOfCallExpression (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:86003:13)
      at visitEachChild (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85603:35)
      at visitor (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:522:20)
      at visitNode (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85353:21)
      at visitEachChildOfReturnStatement (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:86269:13)
      at visitEachChild (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85603:35)
      at visitor (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/@deepkit+type-compiler@1.0.1-alpha.97_typescript@5.0.2/node_modules/@deepkit/type-compiler/dist/cjs/src/compiler.js:522:20)
      at visitArrayWorker (/Users/marcus-sa/Git/marcus-sa/nx-deepkit-react-vite-type-compiler-unexpected-node-error/node_modules/.pnpm/typescript@5.0.2/node_modules/typescript/lib/typescript.js:85415:51)
@marcus-sa
Copy link
Contributor Author

marcus-sa commented Jun 13, 2023 •
edited

Here's the simplest reproduction

function a<T>(t: T) {
    return b<T>(t);
}

function b<T>(t: T): T {
    return t;
}

a(1);

The problem appears to be with generics.

@marcus-sa
Copy link
Contributor Author

marcus-sa commented Jun 20, 2023 •
edited

Can be worked around by adding

/** @reflection never */

marcus-sa added a commit to marcus-sa/deepkit-framework that referenced this issue Aug 9, 2023
@marcus-sa
fix(type-compiler): Node InferType did not pass test 'isEntityName'
1922bcf 
Fixes deepkit#455

Author https://discord.com/channels/759513055117180999/956485210676002816/1138433915221196912

Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
marcus-sa added a commit to marcus-sa/deepkit-framework that referenced this issue Aug 9, 2023
@marcus-sa
fix(type-compiler): Node InferType did not pass test 'isEntityName'
f5cba6f 
Fixes deepkit#455

Author: https://discord.com/channels/759513055117180999/956485210676002816/1138433915221196912

Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
@marcus-sa marcus-sa mentioned this issue Aug 9, 2023
Merged
marcus-sa added a commit to marcus-sa/deepkit-framework that referenced this issue Sep 11, 2023
@marcus-sa
fix(type-compiler): Node InferType did not pass test 'isEntityName'
c494647 
Fixes deepkit#455

Author https://discord.com/channels/759513055117180999/956485210676002816/1138433915221196912

Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
@marcj marcj closed this as completed in #465 Oct 1, 2023
marcj pushed a commit that referenced this issue Oct 1, 2023
@marcus-sa
fix(type-compiler): Node InferType did not pass test 'isEntityName' (#…
74b92fc 
…465)

Fixes #455

Author https://discord.com/channels/759513055117180999/956485210676002816/1138433915221196912

Signed-off-by: Marcus S. Abildskov <8391194+marcus-sa@users.noreply.github.com>
@marcus-sa
Copy link
Contributor Author

@marcj this was never fixed

@marcj
Copy link
Member

marcj commented Nov 16, 2023 •
edited

we need a failing unit test. I assume the code above doesnt fail in our test suite

@marcus-sa marcus-sa mentioned this issue Nov 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(type-compiler): Node InferType did not pass test isEntityName marcus-sa/deepkit-framework
2 participants
@marcj @marcus-sa