fix: fix destructing error if there is no call.method.options

[nikolaymatrosov]

If protobuf files were compiled without --ts_proto_opt=outputServices=generic-definitions, there will be no call.method.options. As a result, trying to destructure it and get the idempotencyLevel value will result in the following error.

TypeError: Cannot destructure property 'idempotencyLevel' of 'call.method.options' as it is undefined.

The fix makes the retry middleware usable for more people who use different ts_proto options and are willing to manually provide retry options to API calls.

[aikoven]

Thanks for your PR!

The call.method.options is a required property, see the type of MethodDescriptor:

nice-grpc/packages/nice-grpc-common/src/MethodDescriptor.ts

Lines 20 to 22 in dd8c896

	options: {
	idempotencyLevel?: 'IDEMPOTENT' | 'NO_SIDE_EFFECTS';
	};

Which means that this object is created incorrectly on the other side. Are you using ts-proto with grpc-js service definitions? Could you share your full ts_proto_opt?

[nikolaymatrosov]

Yes, in the project that I am having issues with ts_proto is called with grpc-js option. https://github.com/yandex-cloud/nodejs-sdk/blob/master/scripts/generate-code.ts#L27

[nikolaymatrosov]

So you're saying I need to fix options and make the object optional to match behavior of grpc-js?

[aikoven]

No, we should rather find out the place where method descriptor is generated from grpc-js descriptor and add the missing field to match the type.

[aikoven]

Apparently the ts-proto-generated grpc-js service definitions were incorrectly detected as ts-proto definitions. Fixed in #305, gonna release soon.

Thank you for the report.