Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply to remove dependency deeplearning4j-datasets from project deeplearning4j-core #10041

Closed
RuiBaiXYZ opened this issue Oct 31, 2023 · 2 comments

Comments

@RuiBaiXYZ
Copy link
Contributor

Issue Description

This is not a bug.
When code reading, I found that deeplearning4j-core does not import anything from deeplearning4j-datasets.
Expect to remove this dependency to keep the project concise.

Version Information

Please indicate relevant versions, including, if relevant:

  • Deeplearning4j version Master branch
  • Platform information (OS, etc) N/A
  • CUDA version, if used N/A
  • NVIDIA driver version, if in use N/A

Additional Information

N/A

Contributing

@agibsonccc
Copy link
Contributor

@RuiBaiXYZ for something this simple mind maybe submitting a PR? I'll get to these last few minor issues after I'm done with GPU testing.

RuiBaiXYZ pushed a commit to RuiBaiXYZ/deeplearning4j that referenced this issue Nov 22, 2023
agibsonccc pushed a commit that referenced this issue Nov 22, 2023
…dependency deeplearning4j-datasets. (#10041) (#10046)

Co-authored-by: RuiBaiXYZ <yinlijun@ruibai.xyz>
@agibsonccc
Copy link
Contributor

Merged here: 6082079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants