Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ND4J: BaseNDArray.castTo(DataType) should return this when correct dtype #7754

Closed
AlexDBlack opened this issue May 18, 2019 · 1 comment
Closed

ND4J: BaseNDArray.castTo(DataType) should return this when correct dtype #7754

AlexDBlack opened this issue May 18, 2019 · 1 comment
Assignees
@AlexDBlack
Labels
Bug Bugs and problems ND4J ND4J Issues

Comments

@AlexDBlack
Copy link
Contributor

This is what we used to do, I don't know when/why it was changed.
i.e., it should be a no-op if already correct type

https://github.com/deeplearning4j/deeplearning4j/blob/master/nd4j/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/linalg/api/ndarray/BaseNDArray.java#L6496-L6506
@AlexDBlack AlexDBlack added Bug Bugs and problems ND4J ND4J Issues labels May 18, 2019
@AlexDBlack AlexDBlack mentioned this issue May 18, 2019
Closed
@AlexDBlack AlexDBlack self-assigned this May 28, 2019
AlexDBlack added a commit that referenced this issue May 28, 2019
@AlexDBlack
#7754 BaseNDArray.castTo - no-op if already correct type
43889f2
@AlexDBlack AlexDBlack mentioned this issue May 28, 2019
Merged
AlexDBlack added a commit that referenced this issue May 28, 2019
@AlexDBlack
Multiple fixes (#7793)
f25dda3 
* #7786 SharedTrainingMaster environment variable fix

* #7785 SameDiffOutputLayer - doInit fix

* #7779 DL4J resources (pretrained models etc) URL: use https

* #7778 Remove DynamicCustomOp.sameDiffBuilder

* Revert #7779

* #7779 Use https resources address that works correctly (certificates match hostname)

* #7754 BaseNDArray.castTo - no-op if already correct type

* Handful of fixes for ND4J sessions tests

* Handful of fixes for ND4J sessions tests

* #7730 Webjars dependencies - lock down versions
@AlexDBlack
Copy link
Contributor Author

#7792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexDBlack AlexDBlack

Labels
Bug Bugs and problems ND4J ND4J Issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDBlack