Build script upgrades #2932
Build script upgrades #2932
Conversation
huitseeker
commented
Feb 27, 2017
•
huitseeker
commented
- adds optional testing
- optional shallow cloning
- makes directory deletion optional, deletes old artifacts in the maven cache instead
- optional detection of backend from the environment
(as long as we use bash ...)
|
Jenkins Build Triggered |
|
Jenkins Build Started |
|
Build finished. No test results found. |
|
Refer to this link for build results (access rights to CI server needed): |
huitseeker
force-pushed
the
buildScriptUpgrades
branch
from
93fc09e
to
521c97f
Compare
|
Jenkins Build Triggered |
|
Jenkins Build Started |
|
Build finished. No test results found. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Jenkins Build Triggered |
|
Jenkins Build Started |
|
Build finished. No test results found. |
|
Refer to this link for build results (access rights to CI server needed): |
| # removes lingering snapshot artifacts from existing maven cache to ensure a | ||
| # clean build | ||
| JAVA_PROJECTS="nd4j datavec deeplearning4j" | ||
| for dirName in $JAVA_PROJECTS; do |
There was a problem hiding this comment.
Something that maybe out of scope here but worth acknowledging: Arbiter,rl4j, and other libs are needed as part of this as well.
|
Is it worth adding extra repositories as a command line flag?
…On Mon, Feb 27, 2017 at 7:50 PM Adam Gibson ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In build-dl4j-stack.sh
<#2932 (comment)>
:
> +echo DELETE_REPOS = "${DELETE_REPOS}"
+echo TEST_ND4J = "${TEST_ND4J}"
+echo TEST_DATAVEC = "${TEST_DATAVEC}"
+echo TEST_DL4J = "${TEST_DL4J}"
+echo MVN_OPTS = "${MVN_OPTS}"
+
+###########################
+# Script execution starts #
+###########################
+
+pushd ..
+
+# removes lingering snapshot artifacts from existing maven cache to ensure a
+# clean build
+JAVA_PROJECTS="nd4j datavec deeplearning4j"
+for dirName in $JAVA_PROJECTS; do
Something that maybe out of scope here but worth acknowledging:
Arbiter,rl4j, and other libs are needed as part of this as well.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2932 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYNr4tQfv-apFsFn9AFzDIQJqKbCywnks5rg5mKgaJpZM4MNiNy>
.
|
|
Jenkins Build Triggered |
|
Jenkins Build Started |
|
Build finished. No test results found. |
|
Refer to this link for build results (access rights to CI server needed): |
|
I agree that other repos are a nice to have, but right now most of our users will be happy with this. |
