New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SameDiff Layer #4426
Closed
Closed
Add SameDiff Layer #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexDBlack
force-pushed
the
ab_samedifflayer
branch
2 times, most recently
from
December 22, 2017 12:16
87d2a32
to
4a96c3b
Compare
AlexDBlack
force-pushed
the
ab_samedifflayer
branch
from
December 28, 2017 10:53
4a96c3b
to
b79d8e4
Compare
AlexDBlack
force-pushed
the
ab_samedifflayer
branch
2 times, most recently
from
January 8, 2018 04:42
bebb0a3
to
db0d7d0
Compare
AlexDBlack
force-pushed
the
ab_samedifflayer
branch
from
February 19, 2018 08:14
7f9e7c6
to
43f85ef
Compare
Closing in favor of: #4675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP DO NOT MERGE
Still a long way to go here. Needs lots of testing.
Adds SameDiff layer. In summary, to add a SameDiff layer:
For now, I'm focusing on the single layer only case (i.e., no building large SameDiff graph across multiple layers). However, I'm keeping this in mind with the API so it can be added later.