New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6284 Why comment out the full connection layer for VGG16 #6348

Merged
merged 9 commits into from Sep 22, 2018

Conversation

Projects
None yet
4 participants
@crazymxm
Copy link
Contributor

crazymxm commented Sep 3, 2018

VGG16 needs full connection layer, so remove the comment out.

#6284 Why comment out the full connection layer for VGG16
VGG16 needs full connection layer,so remove the comment out.

@saudet saudet requested a review from crockpotveggies Sep 3, 2018

@crockpotveggies

This comment has been minimized.

Copy link
Collaborator

crockpotveggies commented Sep 13, 2018

Going to wait for Jenkins to run a test on this and then I'll merge.

@crockpotveggies
Copy link
Collaborator

crockpotveggies left a comment

There was a strange issue on master regarding merge, fixing now.

@saudet

This comment has been minimized.

Copy link
Member

saudet commented Sep 14, 2018

Looks like there is a build failure for the deeplearning4j-zoo module:

[ERROR] COMPILATION ERROR : 

[INFO] -------------------------------------------------------------

[ERROR] /home/jenkins/workspace/deeplearning4j-PR-6348-linux-x86_64-cpu/deeplearning4j/deeplearning4j-zoo/src/main/java/org/deeplearning4j/zoo/model/VGG16.java:[161,50] package DenseLayer does not exist

[ERROR] /home/jenkins/workspace/deeplearning4j-PR-6348-linux-x86_64-cpu/deeplearning4j/deeplearning4j-zoo/src/main/java/org/deeplearning4j/zoo/model/VGG16.java:[159,50] package DenseLayer does not exist

[INFO] 2 errors 

@crazymxm Please fix this!

fix compare error
add DenseLayer import.
@crazymxm

This comment has been minimized.

Copy link
Contributor

crazymxm commented Sep 17, 2018

The compile error has been fixed, @saudet

@@ -181,7 +182,7 @@ public ComputationGraph init() {

@Override
public ModelMetaData metaData() {
return new ModelMetaData(new int[][] {inputShape}, 1, ZooType.CNN);
return null ;//new ModelMetaData(new int[][] {inputShape}, 1, ZooType.CNN);

This comment has been minimized.

@saudet

saudet Sep 17, 2018

Member

Why is this returning null?

crazymxm and others added some commits Sep 17, 2018

recovery metaData
recovery metaData
@saudet

This comment has been minimized.

Copy link
Member

saudet commented Sep 18, 2018

@crockpotveggies Good to merge?

@crockpotveggies

This comment has been minimized.

Copy link
Collaborator

crockpotveggies commented Sep 20, 2018

Waiting for checks to pass and I'll merge it.

@sshepel

This comment has been minimized.

Copy link
Contributor

sshepel commented Sep 21, 2018

@crockpotveggies The tests for deeplearning4j-zoo will not be run because there are some failures in tests for other modules 😞

@crockpotveggies crockpotveggies merged commit 782717b into deeplearning4j:master Sep 22, 2018

0 of 2 checks passed

codeclimate Code Climate is analyzing this code.
Details
continuous-integration/jenkins/pr-head This commit is being built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment