Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6284 Why comment out the full connection layer for VGG16 #6348

Merged
merged 9 commits into from Sep 22, 2018
Merged

#6284 Why comment out the full connection layer for VGG16 #6348

merged 9 commits into from Sep 22, 2018

Conversation

crazymxm
Copy link

@crazymxm crazymxm commented Sep 3, 2018

VGG16 needs full connection layer, so remove the comment out.

@crazymxm
deeplearning4j#6284 Why comment out the full connection layer for VGG16
52e26a4 
VGG16 needs full connection layer,so remove the comment out.
@crockpotveggies
Copy link

Going to wait for Jenkins to run a test on this and then I'll merge.

crockpotveggies
crockpotveggies reviewed Sep 13, 2018
View reviewed changes
Copy link

@crockpotveggies crockpotveggies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a strange issue on master regarding merge, fixing now.

@saudet
Copy link
Contributor

saudet commented Sep 14, 2018

Looks like there is a build failure for the deeplearning4j-zoo module:

[ERROR] COMPILATION ERROR : 

[INFO] -------------------------------------------------------------

[ERROR] /home/jenkins/workspace/deeplearning4j-PR-6348-linux-x86_64-cpu/deeplearning4j/deeplearning4j-zoo/src/main/java/org/deeplearning4j/zoo/model/VGG16.java:[161,50] package DenseLayer does not exist

[ERROR] /home/jenkins/workspace/deeplearning4j-PR-6348-linux-x86_64-cpu/deeplearning4j/deeplearning4j-zoo/src/main/java/org/deeplearning4j/zoo/model/VGG16.java:[159,50] package DenseLayer does not exist

[INFO] 2 errors

@crazymxm Please fix this!

@crazymxm
fix compare error
7290565 
add DenseLayer import.
@crazymxm
Copy link
Author

crazymxm commented Sep 17, 2018 •
edited

The compile error has been fixed, @saudet

saudet
saudet reviewed Sep 17, 2018
View reviewed changes
deeplearning4j/deeplearning4j-zoo/src/main/java/org/deeplearning4j/zoo/model/VGG16.java Outdated
@@ -181,7 +182,7 @@ public ComputationGraph init() {

@Override
public ModelMetaData metaData() {
return new ModelMetaData(new int[][] {inputShape}, 1, ZooType.CNN);
return null ;//new ModelMetaData(new int[][] {inputShape}, 1, ZooType.CNN);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this returning null?

@saudet
Copy link
Contributor

saudet commented Sep 18, 2018

@crockpotveggies Good to merge?

@crockpotveggies
Copy link

Waiting for checks to pass and I'll merge it.

@sshepel
Copy link
Contributor

sshepel commented Sep 21, 2018

@crockpotveggies The tests for deeplearning4j-zoo will not be run because there are some failures in tests for other modules 😞

@crockpotveggies crockpotveggies merged commit 782717b into deeplearning4j:master Sep 22, 2018
@AlexDBlack AlexDBlack mentioned this pull request Nov 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saudet saudet saudet left review comments

@crockpotveggies crockpotveggies crockpotveggies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crazymxm @crockpotveggies @saudet @sshepel