Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create OSGi bundles for ND4J #8083

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create OSGi bundles for ND4J #8083

wants to merge 3 commits into from

Commits on Aug 12, 2019

  1. Make the shaded Jackson module output an OSGi bundle 

    * Minimal changes to the module build, although it appears that this could be simplified
* All Jackson packages exported at the jackson.version

Signed-off-by: Tim Ward <timothyjward@apache.org>
    @timothyjward
    timothyjward committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    4e9f129 View commit details
    Browse the repository at this point in the history

  2. Create an OSGi bundle for the main ND4J API 

    This is the least invasive option for creating an OSGi enabled ND4J bundle, but it could be improved

* Multiple API jars are combined to avoid split package problems, ideally there would be no split packages
* API packages and their versions are determined here, ideally this would be done using annotations in the packages themselves
* Some third party code is included because it is not packaged in OSGi bundles
* Some third party code leaks out through the ND4J API

Signed-off-by: Tim Ward <timothyjward@apache.org>
    @timothyjward
    timothyjward committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    bfc2503 View commit details
    Browse the repository at this point in the history

  3. Create an OSGi bundle for the ND4J Native CPU backend 

    This is the least invasive option for creating an ND4J backend

* The Native Java API, Java Implementation and Native code are all combined into one module
* Each platform creates its own specific OSGi bundle complete with native dependencies
* The Frontend has a requirement on at least one backend being present
* The Frontend logic has been improved to handle backend discovery/loading when it's a separate module
* A simple OSGi sniff test has been added to demonstrate loading an ND Array

Signed-off-by: Tim Ward <timothyjward@apache.org>
    @timothyjward
    timothyjward committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    04fa6a9 View commit details
    Browse the repository at this point in the history