Converging versions of netty modules #9163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shamsulazeem <shamsazeem20@gmail.com>
agibsonccc
requested changes
Jan 24, 2021
ShamsUlAzeem
force-pushed
the
sa/converging-netty-versions
branch
2 times, most recently
from
f365ce3
to
feb87ea
Compare
Signed-off-by: shamsulazeem <shamsazeem20@gmail.com>
ShamsUlAzeem
force-pushed
the
sa/converging-netty-versions
branch
2 times, most recently
from
7a924be
to
3f870c7
Compare
# Conflicts: # datavec/datavec-data/datavec-hadoop/pom.xml # pom.xml
Signed-off-by: shamsulazeem <shamsazeem20@gmail.com>
agibsonccc
requested changes
Feb 19, 2021
agibsonccc
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shamsulazeem shamsazeem20@gmail.com
What changes were proposed in this pull request?
(Solving part of #8724) This PR tries to converge Netty versions throughout the whole stack. There might be hidden issues still related to
ClassNotFoundorNoSuchMethodexceptions. Will look at OSGi alternative in the future.How was this patch tested?
Checked versions with
dependency:treeand compilation of stack without running tests (Leaving it to the CI here)Quick checklist
The following checklist helps ensure your PR is complete: