Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined symbols, Migrate more ints -> sd::LongType #9963

Merged
merged 8 commits into from Apr 21, 2023
Merged

Fix undefined symbols, Migrate more ints -> sd::LongType #9963

merged 8 commits into from Apr 21, 2023

Conversation

agibsonccc
Copy link
Contributor

@agibsonccc agibsonccc commented Apr 20, 2023 •
edited

What changes were proposed in this pull request?

Fixes undefined symbols in libnd4j
Migrates more ints/dimensions to sd::LongType
Prevent linker regressions by adding new compiler flag for no undefined symbols

How was this patch tested?

Built manually

Quick checklist

The following checklist helps ensure your PR is complete:

  • [X ] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
  • [ X] Reviewed the Contributing Guidelines and followed the steps within.
  • [ X] Created tests for any significant new code additions.
  • [ X] Relevant tests for your changes are passing.

@agibsonccc
Remove extra op context changes due to performance regressions
80b980d 
Fix javacpp hack removals due to unsatisfied link on mac
Remove extra nd4j-profiler dependency in tests
@agibsonccc
Fix up unsatisfied links by cleaning up definitions
5264bb6 
Add new compiler flags support for nd4j-native
Add validation for missing method definitions
More clean up on ints/unsigned values to sd::Longs
@agibsonccc
More cuda int -> sd::LongType changes
d7247c5
@agibsonccc agibsonccc requested a review from treo April 20, 2023 08:13
treo
treo previously approved these changes Apr 20, 2023
View reviewed changes
@agibsonccc agibsonccc requested a review from treo April 20, 2023 12:09
treo
treo previously approved these changes Apr 20, 2023
View reviewed changes
@agibsonccc agibsonccc requested a review from treo April 21, 2023 06:29
treo
treo requested changes Apr 21, 2023
View reviewed changes
libnd4j/include/helpers/impl/shape.cpp Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@agibsonccc agibsonccc requested a review from treo April 21, 2023 07:31
treo
treo previously approved these changes Apr 21, 2023
View reviewed changes
@agibsonccc agibsonccc requested a review from treo April 21, 2023 07:43
@agibsonccc agibsonccc merged commit f8bb11d into master Apr 21, 2023
1 check passed
@agibsonccc agibsonccc deleted the ag_misc_mac_fixes branch April 21, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treo treo treo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agibsonccc @treo