Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: removal of GlobalC::UOT #4322

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

jinzx10
Copy link
Collaborator

@jinzx10 jinzx10 commented Jun 6, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

#4079

What's changed?

The global variable "GlobalC::UOT" (an object of class ORB_gen_tables) is removed from the code. Instead, ESolver_KS_LCAO becomes the owner of the only object of class ORB_gen_tables.

Any changes of core modules? (ignore if not applicable)

Various functions & classes relying on GlobalC::UOT now have "const ORB_gen_tables*" as an explicit argument.

@mohanchen mohanchen merged commit 51bdd59 into deepmodeling:develop Jun 7, 2024
13 checks passed
@jinzx10 jinzx10 deleted the GlobalC_UOT_stage1 branch June 7, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants