forked from abacusmodeling/abacus-develop
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Vector to replace new and delete in gint,spilt gint_tools and change Makefile,remove ORB in gint #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodchong
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good step. But future changes like this will need to be carefully examined for performance impact. I tried to solve the problem with some elegant class wrappers, but this had severe performance impacts on some variables.
dzzz2001
reviewed
Jun 13, 2024
mohanchen
reviewed
Jun 13, 2024
mohanchen
approved these changes
Jun 14, 2024
A-006
changed the title
Use Vector to replace new and delete in gint
Use Vector to replace new and delete in gint,spilt gint_tools and change Makefile,remove ORB in gint
Jun 15, 2024
mohanchen
reviewed
Jun 15, 2024
dzzz2001
reviewed
Jun 15, 2024
mohanchen
reviewed
Jun 16, 2024
dzzz2001
reviewed
Jun 17, 2024
mohanchen
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
MeshK
,Meshcell
,bigcell
,meshball
, andgrid_technique
, usevector
instead ofnew
anddelete
. Some parameters should be protected usingprivate
. gint_tools was spilted into 6 files,and must modify the Makefile.Objects here, otherwise there will be issues. Remove the dependency on the ORB parameter in gint; the ORB structure is not needed during the gint calculation process.