-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpa2 model may need a fake communication op to deal with nloc == 0. #3732
Labels
Comments
It seems to me that we should support the situation for |
I agree. |
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 26, 2024
Fix #3732. Removes the special codes for `nloc==0` which has been supported by #4005. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved robustness in tensor handling when inputs are empty. - Enhanced test coverage for parameters in the `test_pair_deepmd_si` and `test_pair_deepmd_mpi` functions, testing scenarios with and without balance arguments. - **Bug Fixes** - Adjusted control flow in the `compute` method to simplify handling of zero atoms or local atoms. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Closed in commit 7907142 |
mtaillefumier
pushed a commit
to mtaillefumier/deepmd-kit
that referenced
this issue
Sep 18, 2024
Fix deepmodeling#3732. Removes the special codes for `nloc==0` which has been supported by deepmodeling#4005. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Improved robustness in tensor handling when inputs are empty. - Enhanced test coverage for parameters in the `test_pair_deepmd_si` and `test_pair_deepmd_mpi` functions, testing scenarios with and without balance arguments. - **Bug Fixes** - Adjusted control flow in the `compute` method to simplify handling of zero atoms or local atoms. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
this should be fixed after wrapping comm op as a pure c++ implementation.
Line: 135
deepmd-kit//source/api_cc/src/DeepPotPT.cc
Lines 132 to 142 in d0fe13c
The text was updated successfully, but these errors were encountered: