Fix bug of single precision model compression #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denghuilu
requested review from
amcadmus and
njzjz
and removed request for
amcadmus
Codecov Report
@@ Coverage Diff @@
## devel #1110 +/- ##
==========================================
- Coverage 75.62% 75.61% -0.02%
==========================================
Files 88 88
Lines 7012 7016 +4
==========================================
+ Hits 5303 5305 +2
- Misses 1709 1711 +2
Continue to review full report at Codecov.
|
njzjz
approved these changes
Sep 6, 2021
|
Does current unit tests also work for single precision? |
The current UT does not include specific single-precision tests. I'm thinking about adding the relative UT... |
amcadmus
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The model compression with float precision has problems in reading model parameters and parameter checking. This PR should be able to fix these problems. Now single-precision model compression can be used normally.