Fix missing std::numeric_limits
#1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge recent development on devel to master
bug fixing: not displaying input doc on github
add doc for short-range tabulated interaction
Bug fixings and add notice for the consistency of TF versions.
master branch update
When the number of sel is smaller than the lammps nbors, the program may have a gpu sorting error.
fix bug of nbor sorting
fix an error in stress by ase interface
master branch update
update compiler support for Ampere architecture devices
fix bug of cuda-11 compilation
The assertions will be bypassed in release building mode
Restarting the pair_style `deepmd` from restart file is not supported
Fix lammps related bugs
fix bug of max_nbor_size usage
fix bug of illegal device memory access
In conda-forge's recent released tensorflow, protobuf is external from tensorflow and not inside the tensorflow directory.
Clang doesn't support this flag, cause an error on osx: > ld: unknown option: --no-as-needed This commit should be cherry-picked to `r1.2` branch.
Do not find protobuf for python
…_on_gnu only enable link what you use on GNU compilers
add more badges
master branch update
add GPU UUID support for DP
This ensures the out file will not be override when LAMMPS restarts. This commit may be conflicted with deepmodeling#392. Commit @5597ea2b49f96e99a52a9779b04b6c12e5a79a04 should be dropped.
Add request not to use image to show error log.
Update bug-report.md
fix class name in deepmodeling#641
* add aliases to Arguments fix deepmodeling#846. * fix a typo in deepmodeling#932
…1041) The flag won't work without language specified. See https://cmake.org/cmake/help/v3.4/variable/CMAKE_COMPILER_IS_GNULANG.html (cherry picked from commit 8bbe565) Co-authored-by: Chun Cai <amoycaic@gmail.com>
Merge devel into master
- Include `<limits>` header, fix missing `std::numeric_limits` when compiling with GCC 11.0.
Codecov Report
@@ Coverage Diff @@
## devel #1113 +/- ##
==========================================
- Coverage 75.61% 74.37% -1.25%
==========================================
Files 88 88
Lines 7016 7000 -16
==========================================
- Hits 5305 5206 -99
- Misses 1711 1794 +83
Continue to review full report at Codecov.
|
amcadmus
approved these changes
Sep 8, 2021
njzjz
pushed a commit
to njzjz/deepmd-kit
that referenced
this pull request
Sep 21, 2023
**expected behavior**:
when `"labeled":true` in `dpgen simplify`, 02.fp will soft-link "labeled
data", and the soft-linked "task dir" will also be created, for format
consistency.
it is expected to be `data.000` and `task.000.000000`,
being respectively guaranteed by funcs `data_system_fmt` and
`fp_task_fmt`
**bug**:
the typo_bug used `data_system_fmt` for the "task dir" instead of
`fp_task_fmt`,
then gives `task.000` instead of `task.000.000000`,
which makes `_check_empty_iter` (who checks `glob.glog("task.000.*")`)
in `generator/run.py` sentence this iter empty,
then `00.train` of the next iter is always skipped.
**consequence**:
this make the "simplify_labeled" process never starts correctly,
no iter0 model presents and randomly-picked data in iter0 are never
trained,
then iter1 gives error that can't finding the graph file from iter0 when
trying copying them due to the train-skip.
**BTW**
thought "simplify_labeled" valuable in some complex or big-data
scenarios but seems not loved by users yet.
pity : (
Signed-off-by: Wanrun Jiang
<58099845+Vibsteamer@users.noreply.github.com>
Signed-off-by: Wanrun Jiang <58099845+Vibsteamer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<limits>header, fix missingstd::numeric_limitswhen compiling with GCC 11.0.