Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for sys_entire, set labeled=False #768

Merged
merged 3 commits into from Jul 5, 2022

Conversation

HuangJiameng
Copy link
Collaborator

Since DP-GEN always deal with Systems (instead of LabeledSystems) here, labeled should be set as False

for sys_entire, set labeled=False
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #768 (54c2f58) into devel (25cb29f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##            devel     #768      +/-   ##
==========================================
- Coverage   34.72%   34.72%   -0.01%     
==========================================
  Files          96       96              
  Lines       16764    16765       +1     
==========================================
  Hits         5821     5821              
- Misses      10943    10944       +1     
Impacted Files Coverage Δ
dpgen/simplify/simplify.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25cb29f...54c2f58. Read the comment docs.

@njzjz
Copy link
Member

njzjz commented Jul 5, 2022

Not always. simplify allows using LabeledSystem without recalculating the points.

There is a parameter labeled to control it. See line 44 and line 376.

dpgen/simplify/simplify.py Outdated Show resolved Hide resolved
@njzjz njzjz merged commit 32b72b4 into deepmodeling:devel Jul 5, 2022
@HuangJiameng HuangJiameng deleted the fix_simplify branch July 26, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants