-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive lower trust level #118
Conversation
Codecov ReportBase: 83.42% // Head: 84.06% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 83.42% 84.06% +0.64%
==========================================
Files 72 72
Lines 3089 3239 +150
==========================================
+ Hits 2577 2723 +146
- Misses 512 516 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
||
def accurate_ratio( | ||
self, | ||
tag = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand what tag
is used for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is reserved for further use, e.g. we want to calculate the accurate ratio of a certain subgroup of the explored configurations.
Candidate frames. A list of tuples: [(traj_idx, frame_idx), ...] | ||
""" | ||
self.candi_picked = [(ii[0], ii[1]) for ii in self.candi] | ||
if max_nframes and max_nframes < len(self.candi_picked): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if max_nframes = 0
is accepted. But to handle this situation, if max_nframes and ...
should be if max_nframes is not None and ...
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, fixed, thanks!
This PR introduce breaking change:
convergence
key in theexplore
session of the input script. This key provides the method of checking exploration convergence. Now the options arefixed-levels
andadaptive-lower
.Main changes of this PR:
ExplorationReportTrustLevels