Skip to content

Commit

Permalink
fix: elmo tests speed
Browse files Browse the repository at this point in the history
* feat: spec in elmo component can be a path relative to deeppavlov_root

* fix: try and fix tests speed on dgx for elmo component
  • Loading branch information
yoptar authored and seliverstov committed Aug 7, 2018
1 parent 614dfa9 commit 65c04ef
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
8 changes: 7 additions & 1 deletion deeppavlov/configs/elmo/elmo_ru-news.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"in": [
"tokens"
],
"spec": "http://lnsigo.mipt.ru/export/deeppavlov_data/elmo_ru-news_wmt11-16_1.5M_steps.tar.gz",
"spec": "embeddings/elmo_ru",
"out": [
"tokens_emb"
]
Expand All @@ -28,6 +28,12 @@
"requirements": [
"../dp_requirements/tf.txt",
"../dp_requirements/elmo.txt"
],
"download": [
{
"url": "http://files.deeppavlov.ai/deeppavlov_data/elmo_ru-news_wmt11-16_1.5M_steps.tar.gz",
"subdir": "embeddings/elmo_ru"
}
]
}
}
3 changes: 2 additions & 1 deletion deeppavlov/models/embedders/elmo_embedder.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import numpy as np
import tensorflow_hub as hub

from deeppavlov.core.commands.utils import expand_path
from deeppavlov.core.common.registry import register
from deeppavlov.core.models.component import Component
from deeppavlov.core.common.log import get_logger
Expand Down Expand Up @@ -68,7 +69,7 @@ class ELMoEmbedder(Component):
"""
def __init__(self, spec: str, dim: int = 1024, pad_zero: bool = False, **kwargs) -> None:

self.spec = spec
self.spec = spec if '://' in spec else str(expand_path(spec))
self.dim = dim
self.pad_zero = pad_zero
self.elmo_outputs, self.sess, self.tokens_ph, self.tokens_length_ph = self._load()
Expand Down

0 comments on commit 65c04ef

Please sign in to comment.