Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Transformers 4.6 with torch_bert_ranker #1532

Merged
merged 4 commits into from
Mar 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deeppavlov/core/common/requirements_registry.json
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
],
"torch_bert_ranker": [
"{DEEPPAVLOV_PATH}/requirements/pytorch16.txt",
"{DEEPPAVLOV_PATH}/requirements/transformers28.txt"
"{DEEPPAVLOV_PATH}/requirements/transformers.txt"
],
"torch_transformers_classifier": [
"{DEEPPAVLOV_PATH}/requirements/pytorch16.txt",
Expand All @@ -226,7 +226,7 @@
],
"torch_bert_ranker_preprocessor": [
"{DEEPPAVLOV_PATH}/requirements/pytorch16.txt",
"{DEEPPAVLOV_PATH}/requirements/transformers28.txt"
"{DEEPPAVLOV_PATH}/requirements/transformers.txt"
],
"transformers_bert_preprocessor": [
"{DEEPPAVLOV_PATH}/requirements/transformers.txt"
Expand Down
16 changes: 8 additions & 8 deletions deeppavlov/models/torch_bert/torch_bert_ranker.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class TorchBertRankerModel(TorchModel):
e.g. {'lr': 0.1, 'weight_decay': 0.001, 'momentum': 0.9}
"""

def __init__(self, pretrained_bert: str,
def __init__(self, pretrained_bert: str = None,
bert_config_file: Optional[str] = None,
n_classes: int = 2,
return_probas: bool = True,
Expand Down Expand Up @@ -97,7 +97,7 @@ def train_on_batch(self, features_li: List[List[InputFeatures]], y: Union[List[i
self.optimizer.zero_grad()

loss, logits = self.model(b_input_ids, token_type_ids=None, attention_mask=b_input_masks,
labels=b_labels)
labels=b_labels, return_dict=False)
loss.backward()
# Clip the norm of the gradients to 1.0.
# This is to help prevent the "exploding gradients" problem.
Expand Down Expand Up @@ -162,10 +162,13 @@ def load(self, fname=None):

if self.pretrained_bert:
log.info(f"From pretrained {self.pretrained_bert}.")
if Path(expand_path(self.pretrained_bert)).exists():
self.pretrained_bert = str(expand_path(self.pretrained_bert))
config = AutoConfig.from_pretrained(self.pretrained_bert,
# num_labels=self.n_classes,
output_attentions=False,
output_hidden_states=False)


self.model = AutoModelForSequenceClassification.from_pretrained(self.pretrained_bert, config=config)

Expand All @@ -190,13 +193,10 @@ def load(self, fname=None):
self.model.num_labels = self.n_classes


elif self.bert_config_file and Path(self.bert_config_file).is_file():
self.bert_config = AutoConfig.from_json_file(str(expand_path(self.bert_config_file)))
if self.attention_probs_keep_prob is not None:
self.bert_config.attention_probs_dropout_prob = 1.0 - self.attention_probs_keep_prob
if self.hidden_keep_prob is not None:
self.bert_config.hidden_dropout_prob = 1.0 - self.hidden_keep_prob
elif self.bert_config_file and expand_path(self.bert_config_file).is_file():
self.bert_config = AutoConfig.from_pretrained(str(expand_path(self.bert_config_file)))
self.model = AutoModelForSequenceClassification.from_config(config=self.bert_config)

else:
raise ConfigError("No pre-trained BERT model is given.")

Expand Down
1 change: 0 additions & 1 deletion deeppavlov/requirements/transformers28.txt

This file was deleted.