Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dff art skill #148

Merged
merged 29 commits into from
May 5, 2022
Merged

Fix/dff art skill #148

merged 29 commits into from
May 5, 2022

Conversation

dmitrijeuseew
Copy link
Contributor

dff_art_skill update dff version and fixes

@dilyararimovna dilyararimovna changed the base branch from main to dev May 4, 2022 06:08
Copy link
Collaborator

@dilyararimovna dilyararimovna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ты используешь новую версию dff, для нее используется папка common/dff, другие - для старой версии dff.

annotations = user_uttr["annotations"]
def extract_entity(ctx, entity_type):
user_uttr: dict = ctx.misc.get("agent", {}).get("dialog", {}).get("human_utterances", [{}])[-1]
annotations = user_uttr.get("annotations", {})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ты используешь новую версию dff, для нее используется папка common/dff, другие - для старой версии dff.

if cur_wiki_page:
wiki_page_content_list = memory.get("wiki_page_content", [])
used_wiki_page_nums = shared_memory.get("used_wiki_page_nums", {}).get(cur_wiki_page, [])
used_wiki_page_nums = wiki.get("used_wiki_page_nums", {}).get(cur_wiki_page, [])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ты используешь новую версию dff, для нее используется папка common/dff, другие - для старой версии dff.

def facts(vars):
return provide_facts_request(vars)
def facts(ctx, actor):
return provide_facts_request(ctx, actor)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ты используешь новую версию dff, для нее используется папка common/dff, другие - для старой версии dff.

def response(vars):
return provide_facts_response(vars, page_source, wiki_page)
def response(ctx: Context, actor: Actor, *args, **kwargs):
return provide_facts_response(ctx, actor, page_source, wiki_page)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ты используешь новую версию dff, для нее используется папка common/dff, другие - для старой версии dff.

@dilyararimovna dilyararimovna merged commit 224288a into dev May 5, 2022
@dilyararimovna dilyararimovna deleted the fix/dff_art_skill branch May 5, 2022 15:17
IgnatovFedor pushed a commit that referenced this pull request Jan 24, 2024
* format everything

* make short summary shorter; add special formatting instructions for question answering

* add part about analysing messages to PM prompt (Ira's request)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants