Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing kwargs to LM loading (e.g. proxy) #132

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Fix passing kwargs to LM loading (e.g. proxy) #132

merged 1 commit into from
Oct 31, 2019

Conversation

cregouby
Copy link
Contributor

No description provided.

@tholor tholor mentioned this pull request Oct 31, 2019
Closed
@tholor tholor self-requested a review October 31, 2019 10:38
@tholor tholor self-assigned this Oct 31, 2019
@tholor
Copy link
Member

tholor commented Oct 31, 2019 •
edited

Thanks, looks good! This will help to fix the Language model part of the proxy issue (#115 )

@tholor tholor changed the title Fix https://github.com/deepset-ai/FARM/issues/115 Fix passing kwargs to LM loading (e.g. proxy) #115 Oct 31, 2019
@tholor tholor changed the title Fix passing kwargs to LM loading (e.g. proxy) #115 Fix passing kwargs to LM loading (e.g. proxy) Oct 31, 2019
@tholor tholor added bug Something isn't working part: model enhancement New feature or request and removed bug Something isn't working labels Oct 31, 2019
@tholor tholor merged commit 36a2763 into deepset-ai:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor Awaiting requested review from tholor

Assignees

@tholor tholor

Labels
enhancement New feature or request part: model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cregouby @tholor