-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests working on Windows #637
Conversation
…m\modeling\prediction_head.py'
After the first commit, I noticed this error on Windows test (note that from side the test on Linux always run successfully):
So the second commit is need to fix that. |
After the first two commits, there is only one test that fails on Windows:
I see that this refer to # Check if DDP is initialized
try:
rank = torch.distributed.get_rank()
except AssertionError:
rank = -1 Any suggestions to make this working also on windows test? |
My current proposal is to exclude Let me know what do you think. |
Hey @ftesser thanks for looking into this. The DDP module is quite important for making DPR trainable so excluding it would not be preferred. Looking into Pytorch support for DDP in windows I found this PR: pytorch/pytorch#45335 which was merged on Sep 25th. So this code is only in the newest pytorch 1.7.0 release (we are currently using pytorch 1.6.0). So actionable insights: We want to do a FARM release later this week, after this we can increment the pytorch version and see if this fixes the DDP issues. Would that be a solution for you? Of course you can try updating pytorch beforehand yourself, we would appreciate your insights. |
Thanks @Timoeller for your feedback. Just a note about this PR, commit 0aedd05 solves a UnicodeDecodeError, this should be applied in all cases. |
Sorry for the delay @ftesser We also quickly tested updating to pytorch in #660 which produced failing onnx conversion tests. Unfortunately we will be able to look into this with the start of the new year. I will merge you PR now to include this nice patch in the coming release. |
This PR is related to #636.
It will be an incremental PR, since I see that after this first commit, some others changes are needed to successfully run all the tests on Windows.
This first commit remove the not used 'from torch.distributed import all_gather' from 'farm\modeling\prediction_head.py'. There is also a newline added here.