Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLFlowLogger can be disabled #650

Merged
merged 3 commits into from
Dec 4, 2020
Merged

MLFlowLogger can be disabled #650

merged 3 commits into from
Dec 4, 2020

Conversation

brandenchan
Copy link
Contributor

Related to #616.

To disable MLFlow logging, you simply call MLFLowLogger.disable(). ML Logging is now turned off in the Inferencer by default.

Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a code comment.

Apart from that, many tests are failing, then it OOMs with code 137. Can this be related to these changes?

farm/utils.py Outdated
@@ -95,6 +95,8 @@ class BaseMLLogger:
This class can be extended to implement custom logging backends like MLFlow, Tensorboard, or Sacred.
"""

disable = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that needed?

Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandenchan brandenchan merged commit 1ae1b71 into master Dec 4, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants