Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pipeline for better generalizability & Add TransformersReader #1

Merged
merged 5 commits into from
Jan 13, 2020

Conversation

tholor
Copy link
Member

@tholor tholor commented Jan 13, 2020

Add an option to use QA models from huggingface's Transformers as a Reader.

Advantages:

  • users can leverage quite easily other community models (from here: https://huggingface.co/models)
  • simpler workflow for transformer users to use their own models (no need to convert to FARM model)

Hand in hand with this addition, it became clear that we want the pipeline to be more generalizable:

  • let the retriever return documents and not only indexes+scores
  • don't require the retriever to have a df in memory with the docs (needed for scaling, e.g. with elasticsearch backend)
  • make input to reader.predict more explicit
  • simplify the format of the dict returned by reader.predict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant