Prevent merge of same questions on different documents during evaluation #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystack into duplicate_question
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
brandenchan
changed the title
brandenchan
changed the title
tholor
approved these changes
Jun 1, 2021
…ystack into duplicate_question
|
thank you so much @brandenchan for implementing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is raised here (#933). This PR solves this by using a tuple of id and question when aggregating labels. This is done in a few different functions where labels are loaded.
This is a recreation of #1030 and #1100 in order to get a cleaner diff (I rebased and merged locally but Github does not show a clean post-rebase diff)