Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add L2 support for FAISS HNSW #1138

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Add L2 support for FAISS HNSW #1138

merged 1 commit into from
Jun 4, 2021

Conversation

brandenchan
Copy link
Contributor

Allows FAISS HNSW to be initialized with L2 similarity. Also allows for more DocumentStore options in test/benchmarks/retriever_simplified.py

@brandenchan brandenchan requested a review from tholor June 3, 2021 14:42
@brandenchan brandenchan self-assigned this Jun 3, 2021
tholor
tholor approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tholor tholor merged commit c513865 into master Jun 4, 2021
@tholor tholor deleted the simplified_benchmark branch June 4, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees

@brandenchan brandenchan

Labels
topic:accuracy topic:document_store topic:eval topic:speed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandenchan @tholor