Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues caused due to mypy upgrade #1165

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Fixing issues caused due to mypy upgrade #1165

merged 1 commit into from
Jun 9, 2021

Conversation

lalitpagaria
Copy link
Contributor

Proposed changes:
To fix #1161

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@lalitpagaria lalitpagaria requested a review from tholor June 9, 2021 11:32
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tholor tholor merged commit db17d73 into master Jun 9, 2021
@tholor tholor deleted the fix_mypy branch June 9, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking changes in newer mypy version
2 participants