Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scaffold for defining custom components for Pipelines #1205

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Add scaffold for defining custom components for Pipelines #1205

merged 2 commits into from
Jun 23, 2021

Conversation

oryx1729
Copy link
Contributor

@oryx1729 oryx1729 commented Jun 17, 2021 •
edited
Loading

Related issue: #955

@oryx1729 oryx1729 requested a review from tholor June 17, 2021 13:45
@oryx1729 oryx1729 requested a review from tholor June 22, 2021 15:06
tholor
tholor approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

FYI @guillim

@oryx1729 oryx1729 merged commit afee4f3 into master Jun 23, 2021
@oryx1729 oryx1729 deleted the custom-componen-rest-api branch June 23, 2021 10:01
@guillim
Copy link
Contributor

guillim commented Jun 23, 2021

@MichaelBitard have a look at the File Changed in this PR : it will ease a bit our Ansible script :)

@oryx1729
Copy link
Contributor Author

@guillim @MichaelBitard would like to hear feedback if this solution works for you 🙂

@MichaelBitard
Copy link
Contributor

Yes it will simplify stuff for us. That's great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oryx1729 @guillim @MichaelBitard @tholor