Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small UI and REST API fixes #1223

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Small UI and REST API fixes #1223

merged 2 commits into from
Jun 24, 2021

Conversation

tholor
Copy link
Member

@tholor tholor commented Jun 24, 2021 •
edited
Loading

Proposed changes:

  • top_k_reader and top_k_retriever are now passed correctly in API requests
  • minor changes and documentation in UI

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code

lalitpagaria
lalitpagaria approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@lalitpagaria lalitpagaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tholor tholor merged commit 2caeea0 into master Jun 24, 2021
@tholor tholor deleted the api_ui_fixes branch June 24, 2021 07:53
@tholor tholor mentioned this pull request Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitpagaria lalitpagaria lalitpagaria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tholor @lalitpagaria