New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import in Milvus2DocumentStore #1646

Merged

ZanSara merged 1 commit into master from fix_milvus2

Oct 26, 2021

Contributor

ZanSara commented Oct 26, 2021

Issues removed:

A generic import from module (from haystack.document_stores import SQLDocumentStore from within haystack/document_stores/)
A circular import with BaseRetriever for typing


          Fix import in Milvus2DocumentStore to import directly from the file a…

d7b0dca

…nd remove circular import with retriever

ZanSara requested a review from tholor

October 26, 2021 07:52

tholor approved these changes

View reviewed changes

tholor added the topic:document_store label

ZanSara merged commit 6f6f235 into master

ZanSara deleted the fix_milvus2 branch

October 26, 2021 09:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment