Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import in Milvus2DocumentStore #1646

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Fix import in Milvus2DocumentStore #1646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions haystack/document_stores/milvus2x.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import logging
from typing import Any, Dict, Generator, List, Optional, Union
from typing import TYPE_CHECKING, Any, Dict, Generator, List, Optional, Union

if TYPE_CHECKING:
from haystack.nodes.retriever.base import BaseRetriever

import numpy
import numpy as np
Expand All @@ -8,8 +11,7 @@
from tqdm import tqdm

from haystack.schema import Document
from haystack.document_stores import SQLDocumentStore
from haystack.nodes.retriever.base import BaseRetriever
from haystack.document_stores.sql import SQLDocumentStore
from haystack.document_stores.base import get_batches_from_generator


Expand Down Expand Up @@ -341,7 +343,7 @@ def _get_field_to_idx(connection, index):

def update_embeddings(
self,
retriever: BaseRetriever,
retriever: 'BaseRetriever',
index: Optional[str] = None,
batch_size: int = 10_000,
update_existing_embeddings: bool = True,
Expand Down