Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move azure-core pin into the dev dependency list #3022

Merged
merged 1 commit into from Aug 11, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Aug 11, 2022

Related Issues

Proposed Changes:

  • Move the azure-core<1.23 pin from the core dependency list into dev with pydoc-markdown, to allow Bazel to properly freeze Haystack dependencies on non-development installations.

How did you test it?

Manual testing by the affected contributor.

Notes for the reviewer

Wait for @tanertopal to confirm the fix works for them.

Checklist

Copy link
Member

@tstadel tstadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! What is a bit worrisome here is that the tests will always run a different version of azure-core than "normal" installations. As the differences between those versions should not be dramatic and are restricted to azureformrecognizer, this is OK.
Anyways, if we encounter any problems with that, pinning msrest<0.7 would be an alternative solution to this change.

@ZanSara
Copy link
Contributor Author

ZanSara commented Aug 11, 2022

Great! I did the same reasoning. We should also verify if the pin to that specific beta of azure-form-recognizer if really necessary, that can solve a lot of problems in the future.

@ZanSara ZanSara merged commit fc8ecbf into master Aug 11, 2022
@ZanSara ZanSara deleted the move-azurecore-pin-in-dev branch August 11, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency resolution for azure-core failing due to transitive depdendencies
2 participants