Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PromptHub integration in PromptNode #4879

Merged
merged 53 commits into from
May 23, 2023
Merged

PromptHub integration in PromptNode #4879

merged 53 commits into from
May 23, 2023

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented May 10, 2023 •
edited
Loading

Related Issues

Proposed Changes:

  • Removes the add/remove mechanism for PromptTemplate
  • Adds support for PromptHub lookups and loading prompts from file
  • Changes get_default_prompt_template into a property called default_prompt_template
  • Update tests

How did you test it?

  • TODO local run of unit tests
  • CI

Notes for the reviewer

keep in mind the two blockers.

@ZanSara ZanSara changed the title [PromptHub](https://prompthub.deepset.ai/) integration in PromptNode PromptHub integration in PromptNode May 10, 2023
@ZanSara ZanSara requested a review from vblagoje May 15, 2023 17:54
@ZanSara ZanSara marked this pull request as ready for review May 15, 2023 17:54
@ZanSara ZanSara requested a review from a team as a code owner May 15, 2023 17:54
@ZanSara ZanSara removed the request for review from a team May 15, 2023 17:54
@ZanSara ZanSara requested a review from silvanocerza May 22, 2023 11:21
@ZanSara @silvanocerza
Update haystack/nodes/prompt/prompt_node.py
f7c2321 
Co-authored-by: Silvano Cerza <3314350+silvanocerza@users.noreply.github.com>
@ZanSara ZanSara merged commit 949b1b6 into main May 23, 2023
@ZanSara ZanSara deleted the prompthub-integration branch May 23, 2023 13:23
@silvanocerza silvanocerza mentioned this pull request May 23, 2023
Merged
@julian-risch julian-risch mentioned this pull request Jun 21, 2023
Closed
@ZanSara ZanSara mentioned this pull request Jun 21, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuanaCelik TuanaCelik TuanaCelik left review comments

@vblagoje vblagoje vblagoje approved these changes

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
breaking change topic:agent topic:build/distribution topic:dependencies topic:LLM topic:promptnode topic:tests type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch prompts from Prompt Hub
5 participants
@ZanSara @coveralls @vblagoje @silvanocerza @TuanaCelik