Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: avoid importing the weaviate client directly from the test module #4945

Merged
merged 1 commit into from
May 18, 2023
Merged

test: avoid importing the weaviate client directly from the test module #4945

merged 1 commit into from
May 18, 2023

Conversation

masci
Copy link
Contributor

@masci masci commented May 17, 2023

Related Issues

-n/a

Proposed Changes:

Fix the mocking introduced with #4805 to avoid importing the client from the test module

How did you test it?

Tested locally

Notes for the reviewer

Stumbled upon this while trying to unblock #4028

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added tests that demonstrate the correct behavior of the change
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@masci masci requested a review from a team as a code owner May 17, 2023 16:45
@masci masci requested review from vblagoje and removed request for a team May 17, 2023 16:45
@masci masci changed the title avoid importing the weaviate client directly test: avoid importing the weaviate client directly from the test module May 17, 2023
@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 38.239%. Remained the same when pulling 4247d75 on massi/weaviate-mock into 9d52998 on main.

@masci masci self-assigned this May 18, 2023
@masci masci merged commit 58acef7 into main May 18, 2023
@masci masci deleted the massi/weaviate-mock branch May 18, 2023 14:08
@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees

@masci masci

Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:document_store topic:tests topic:weaviate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masci @coveralls @silvanocerza