refactor: Generate eval result in separate method #5001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:pipeline
type:documentation
Pull Request Test Coverage Report for Build 5067539591
💛 - Coveralls |
This was referenced May 23, 2023
vblagoje
reviewed
May 24, 2023
| custom_document_id_field: Optional[str] = None, | ||
| context_matching_min_length: int = 100, | ||
| context_matching_boost_split_overlaps: bool = True, | ||
| context_matching_threshold: float = 65.0, |
There was a problem hiding this comment.
Out of curiosity - where did these defaults like context_matching_threshold and their values come from?
There was a problem hiding this comment.
They come from eval_batch.
wochinge
reviewed
Jun 28, 2023
| context_matching_boost_split_overlaps: bool = True, | ||
| context_matching_threshold: float = 65.0, | ||
| use_auth_token: Optional[Union[str, bool]] = None, | ||
| ) -> EvaluationResult: | ||
| eval_result = EvaluationResult() | ||
| if add_isolated_node_eval: |
There was a problem hiding this comment.
this would need to happen before we do the batch evaluation
There was a problem hiding this comment.
@bogdankostic This causes isolated evaluation to be omitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
This PR creates a separate method for generating eval results from batch predictions.
How did you test it?
Manual tests + CI
Notes for the reviewer
This is needed for benchmarking, as we want to get performance metrics for Pipelines but want to measure pure inference time without the overhead of calculating the metrics.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.