Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support OpenAI-Organization for authentication #5292

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jul 6, 2023

Related Issues

Proposed Changes:

  • Added the (optional) OpenAI-Organization string to headers for requests to OpenAI API
  • In OpenAIInvocationLayer, OpenAIAnswerGenerator and EmbeddingRetriever

How did you test it?

New unit tests for each node involved.

Checklist

@github-actions github-actions bot added topic:retriever type:documentation Improvements on the docs labels Jul 6, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 6, 2023

Pull Request Test Coverage Report for Build 5484968917

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 128 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.09%) to 44.744%

Files with Coverage Reduction New Missed Lines %
nodes/retriever/_openai_encoder.py 8 78.02%
nodes/prompt/invocation_layer/open_ai.py 10 80.85%
nodes/answer_generator/openai.py 14 85.0%
nodes/answer_generator/base.py 20 54.88%
nodes/retriever/web.py 23 71.85%
nodes/retriever/dense.py 53 26.45%
Totals Coverage Status
Change from base Build 5476747209: 0.09%
Covered Lines: 10309
Relevant Lines: 23040

💛 - Coveralls

@anakin87 anakin87 marked this pull request as ready for review July 7, 2023 09:33
@anakin87 anakin87 requested a review from a team as a code owner July 7, 2023 09:33
@anakin87 anakin87 requested review from silvanocerza and removed request for a team July 7, 2023 09:33
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR! 🚀

@anakin87 anakin87 merged commit 90ff381 into main Jul 7, 2023
90 checks passed
@anakin87 anakin87 deleted the add-openai-organization branch July 7, 2023 10:02
@anakin87 anakin87 mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OpenAI-Organization field to the request header
3 participants