feat: Change type of PromptModel invocation_layer_class init param #6497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
requested review from
dfokina and
anakin87
and removed request for
a team
1 task
anakin87
pushed a commit
that referenced
this pull request
Dec 15, 2023
anakin87
pushed a commit
that referenced
this pull request
Dec 21, 2023
…eciprocal rank fusion (#5704) * Change type of PromptModel invocation_layer_class init param (#6497) * fix: mypy `"str" not callable` for `PromptModelInvocationLayer` (#6529) * cast to PromptModelInvocationLayer * fix pylint pointless-exception-statement * use two variables to avoid re-assignment * black * use mocked tokenizer in unit test * Add normalization and weighting for `JoinDocuments` reciprocal rank fusion * Add weights and score normalization for reciprocal rank fusion in JoinDocuments node. * Fix black-jupyter * Fix JoinDocuments test for rrf + score normalization --------- Co-authored-by: Silvano Cerza <3314350+silvanocerza@users.noreply.github.com> Co-authored-by: Julian Risch <julian.risch@deepset.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
This PR changes
PromptModelinvocation_layer_classinit parameter type. Now it can either be aPromptModelInvocationLayerclass orstrpointing to the invocation layer class.If
stris used the class module will be imported automatically.Example usage:
How did you test it?
I added a unit test and tested serialisation manually.
Notes for the reviewer
This is not a complete fix to the serialisation issue but at least it makes possible to set a custom
invocation_layer_classin YAML.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.