Fix: Fix Pipeline.run() running components with only defaults in the wrong order #7426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
2.x
silvanocerza
requested review from
davidsbatista
and removed request for
julian-risch
davidsbatista
approved these changes
Mar 26, 2024
Pull Request Test Coverage Report for Build 8438251670Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
This broke something 😢 |
silvanocerza
added a commit
that referenced
this pull request
Apr 8, 2024
…wrong order (#7426) * Fix Pipeline.run() running components with only defaults in the wrong order * Add release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Changes the behaviour of
Pipeline.run()to treat Components that have only default inputs the same way we treat Component with Variadic that are marked as lazy. This is done only when trying to remove Components from the internalwaiting_for_inputqueue.How did you test it?
I added a new unit test and verified other weren't breaking.
Notes for the reviewer
N/A
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.