Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Pipeline.run() getting stuck in a loop even though there are components that can run #7434

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

silvanocerza
Copy link
Contributor

Related Issues

Proposed Changes:

Add a missing check in Pipeline.run() that prevented Components with only default inputs to run when the Pipeline is stuck in a loop.

How did you test it?

I ran the failing end to end test that was failing.

Notes for the reviewer

No need for release notes as the bug was created with #7426 and it still has not been released.

Checklist

@silvanocerza silvanocerza added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Mar 27, 2024
@silvanocerza silvanocerza self-assigned this Mar 27, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner March 27, 2024 11:54
@silvanocerza silvanocerza requested review from masci and removed request for a team March 27, 2024 11:55
@github-actions github-actions bot added 2.x Related to Haystack v2.0 topic:core labels Mar 27, 2024
@coveralls
Copy link
Collaborator

coveralls commented Mar 27, 2024

Pull Request Test Coverage Report for Build 8465791582

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 89.532%

Files with Coverage Reduction New Missed Lines %
core/pipeline/pipeline.py 4 93.85%
Totals Coverage Status
Change from base Build 8450062887: 0.05%
Covered Lines: 5568
Relevant Lines: 6219

💛 - Coveralls

@silvanocerza silvanocerza added this to the 2.0.1 milestone Mar 27, 2024
@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Mar 28, 2024
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvanocerza silvanocerza merged commit 6e28969 into main Mar 28, 2024
20 checks passed
@silvanocerza silvanocerza deleted the fix-pipeline-run-stuck-loop branch March 28, 2024 11:31
silvanocerza added a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:core topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants