Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove fetch_from_http function #7657

Merged
merged 5 commits into from
May 7, 2024
Merged

chore: remove fetch_from_http function #7657

merged 5 commits into from
May 7, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented May 7, 2024

Related Issues

  • fixes n/a

Proposed Changes:

  • Remove the function fetch_archive_from_http
  • Remove all the examples where it was used

How did you test it?

Notes for the reviewer

Checklist

@masci masci requested a review from silvanocerza May 7, 2024 10:44
@masci masci requested review from a team as code owners May 7, 2024 10:44
@masci masci requested review from dfokina and anakin87 and removed request for a team May 7, 2024 10:44
@github-actions github-actions bot added the type:documentation Improvements on the docs label May 7, 2024
@anakin87
Copy link
Member

anakin87 commented May 7, 2024

It is used in several tutorials: https://github.com/search?q=repo%3Adeepset-ai%2Fhaystack-tutorials+fetch_archive_from_http&type=code

@masci masci merged commit 2cadee5 into v1.x May 7, 2024
53 checks passed
@masci masci deleted the remove-fetch-from-http branch May 7, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@dfokina dfokina Awaiting requested review from dfokina dfokina is a code owner automatically assigned from deepset-ai/documentation

@anakin87 anakin87 Awaiting requested review from anakin87 anakin87 is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
topic:CI topic:file_converter type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@masci @anakin87 @silvanocerza