fix: Fix issue that could lead to RCE if using unsecure Jinja templates in dynamic prompt builders #8096
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
requested review from
dfokina and
vblagoje
and removed request for
a team and
vblagoje
shadeMe
approved these changes
Jul 26, 2024
silvanocerza
force-pushed
the
dynamic-prompt-builder-fix
branch
2 times, most recently
from
327dcf1
to
25bd9a7
Compare
… dynamic prompt builders
silvanocerza
force-pushed
the
dynamic-prompt-builder-fix
branch
from
25bd9a7
to
bff331e
Compare
Pull Request Test Coverage Report for Build 10114113783Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
Brings fix from #8095 in for dynamic prompt builders.
How did you test it?
I ran tests locally.
Notes for the reviewer
N/A
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.