Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Grammarly over README.md #890

Merged
merged 8 commits into from
Mar 16, 2021
Merged

Run Grammarly over README.md #890

merged 8 commits into from
Mar 16, 2021

Conversation

peterdemin
Copy link
Contributor

@peterdemin peterdemin commented Mar 12, 2021

I copy-pasted README.md to the premium account on https://grammarly.com and reviewed/applied all suggested changes.

@tholor tholor requested a review from aantti March 12, 2021 16:11
@tholor
Copy link
Member

tholor commented Mar 12, 2021

Cool, thanks for the PR @peterdemin . We will review in detail but from a quick look, I already spotted many good fixes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@aantti
Copy link
Contributor

aantti commented Mar 15, 2021

Thanks so much @peterdemin for taking the time to do it! I've only changed a couple of things that just look a bit more readable. Grammarly is often a bit opinionated :)

peterdemin and others added 7 commits March 15, 2021 09:06
Co-authored-by: Andrey A. <56412611+aantti@users.noreply.github.com>
Co-authored-by: Andrey A. <56412611+aantti@users.noreply.github.com>
Co-authored-by: Andrey A. <56412611+aantti@users.noreply.github.com>
Co-authored-by: Andrey A. <56412611+aantti@users.noreply.github.com>
Co-authored-by: Andrey A. <56412611+aantti@users.noreply.github.com>
Co-authored-by: Andrey A. <56412611+aantti@users.noreply.github.com>
@peterdemin
Copy link
Contributor Author

All fixes commited

@peterdemin
Copy link
Contributor Author

This PR is ready to be merged 😉

@aantti
Copy link
Contributor

aantti commented Mar 16, 2021

Thank again!

@aantti aantti merged commit 992277e into deepset-ai:master Mar 16, 2021
@peterdemin
Copy link
Contributor Author

You're welcome, thanks for maintaining this awesome project!

@peterdemin peterdemin deleted the patch-1 branch March 16, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants