Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FAISS import conditional #970

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Make FAISS import conditional #970

merged 1 commit into from
Apr 14, 2021

Conversation

oryx1729
Copy link
Contributor

@oryx1729 oryx1729 commented Apr 14, 2021 •
edited
Loading

The FAISS library installation does not work out-of-the-box on some architectures like ppc64le. This PR enables Haystack to work without FAISS.

@oryx1729 oryx1729 requested a review from Timoeller April 14, 2021 14:33
Timoeller
Timoeller approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@oryx1729 oryx1729 merged commit 237172f into master Apr 14, 2021
@oryx1729 oryx1729 deleted the faiss-import branch April 14, 2021 15:34
@oryx1729 oryx1729 mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oryx1729 @Timoeller