test: fixing write ack tests and submodule dependencies

deepstreamIO · Apr 8, 2017 · 0544558 · 0544558
1 parent 83e796f
commit 0544558
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/src/record/record.js b/src/record/record.js
@@ -169,13 +169,11 @@ Record.prototype.set = function (pathOrData, dataOrCallback, callback) {
 
   if (oldValue === newValue) {
     if (typeof callback === 'function') {
-      if (this._client.getConnectionState() === C.CONNECTION_STATE.OPEN) {
-        utils.requestIdleCallback(callback)
-      } else {
-        utils.requestIdleCallback(
-          callback.bind(this, 'Connection error: error updating record as connection was closed')
-        )
+      let errorMessage = null
+      if (this._client.getConnectionState() !== C.CONNECTION_STATE.OPEN) {
+        errorMessage = 'Connection error: error updating record as connection was closed'
       }
+      utils.requestIdleCallback(() => callback(errorMessage))
     }
     return this
   }
@@ -186,7 +184,7 @@ Record.prototype.set = function (pathOrData, dataOrCallback, callback) {
     config.writeSuccess = true
     if (this._client.getConnectionState() !== C.CONNECTION_STATE.OPEN) {
       utils.requestIdleCallback(
-        callback.bind(this, 'Connection error: error updating record as connection was closed')
+        () => callback('Connection error: error updating record as connection was closed')
       )
     } else {
       this._setUpCallback(this.version, callback)

diff --git a/test-e2e/features b/test-e2e/features
diff --git a/test-specs/features b/test-specs/features