Fixes #32 Subscribing to empty list returns object instead of array

deepstreamIO · Dec 12, 2015 · 6d6a8c8 · 6d6a8c8
1 parent c9a74f4
commit 6d6a8c8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/record/list.js b/src/record/list.js
@@ -170,6 +170,10 @@ List.prototype.subscribe = function() {
 		throw new Error( 'path is not supported for List.subscribe' );
 	}
 
+	parameters.callback = function( callback ) {
+		callback( this.getEntries() );
+	}.bind( this, parameters.callback );
+
 	this._record.subscribe( parameters );
 };
 

diff --git a/test-unit/unit/record/list-change-listenerSpec.js b/test-unit/unit/record/list-change-listenerSpec.js
@@ -17,15 +17,25 @@ describe( 'lists contain arrays of record names', function(){
 		return callback;
 	}
 
-	it( 'creates the list', function(){
+	it( 'creates the list', function( done ){
+		var callback = jasmine.createSpy( 'empty-subscribe' );
+
 		list = new List( recordHandler, 'someList', {} );
+
 		recordHandler._$handle({
 			topic: 'R',
 			action: 'R',
-			data: [ 'someList', 1, '[]' ]
+			data: [ 'someList', 1, '{}' ]
 		});
+
 		expect( list.getEntries() ).toEqual( [] );
 		expect( list.isEmpty() ).toBe( true );
+
+		list.whenReady( function() {
+			list.subscribe( callback, true );
+			expect( callback ).toHaveBeenCalledWith( [] );
+			done();
+		});
 	});
 
 	it( 'works without any listeners', function(){